pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <piaozhe...@gmail.com>
Subject Re: Review Request 23296: PIG-3935: Port more mini cluster tests to Tez - part 5
Date Mon, 07 Jul 2014 19:16:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23296/#review47410
-----------------------------------------------------------

Ship it!


Looks good to me. (I haven't run full unit tests).


http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java
<https://reviews.apache.org/r/23296/#comment83148>

    You can use isLimited() instead of getLimit() != -1.


- Cheolsoo Park


On July 7, 2014, 4:24 a.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23296/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 4:24 a.m.)
> 
> 
> Review request for pig, Cheolsoo Park and Daniel Dai.
> 
> 
> Bugs: PIG-3935
>     https://issues.apache.org/jira/browse/PIG-3935
> 
> 
> Repository: pig
> 
> 
> Description
> -------
> 
> Fixes following tests
> 
> TestEvalPipeline2.java
> TestLimitAdjuster.java
> TestLimitVariable.java
> TestPigParser.java
> TestPigSplit.java
> TestStore.java
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/pig/trunk/build.xml 1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/shims/test/hadoop23/org/apache/pig/test/TezMiniCluster.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigConfiguration.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PlanPrinter.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/MultiQueryOptimizerTez.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/POLocalRearrangeTez.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/POValueOutputTez.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/PigProcessor.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/ReadScalarsTez.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezPrinter.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/optimizers/UnionOptimizer.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/tools/grunt/GruntParser.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/tools/pigstats/tez/TezTaskStats.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/MiniGenericCluster.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestGrunt.java 1608292

>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestLimitAdjuster.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestLimitVariable.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestParser.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigSplit.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestScalarAliases.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestStore.java 1608292

>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestTmpFileCompression.java
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/TEZC16.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/TEZC4.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-3.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-5.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld
1608292 
>   http://svn.apache.org/repos/asf/pig/trunk/test/tez-tests 1608292 
> 
> Diff: https://reviews.apache.org/r/23296/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit tests with auto parallelism turned off. There is an existing issue where
tasks are stuck with auto parallel turned on. This fixed BigData_9 as well.
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message