pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohini Palaniswamy" <rohini.adi...@gmail.com>
Subject Re: Review Request 21405: PIG-3925: Port more mini cluster tests to Tez - part 4
Date Fri, 16 May 2014 16:16:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21405/
-----------------------------------------------------------

(Updated May 16, 2014, 4:16 p.m.)


Review request for pig, Cheolsoo Park and Daniel Dai.


Changes
-------

Rebased patch after PIG-3918, removing TestBuiltin.java changes


Bugs: PIG-3925
    https://issues.apache.org/jira/browse/PIG-3925


Repository: pig


Description
-------

Ported following test cases
TestFRJoin.java
TestFRJoinNullValue.java
TestGrunt.java
TestImplicitSplit.java
TestInputOutputMiniClusterFileValidator.java
TestJoin.java
TestJoinSmoke.java
TestKeyTypeDiscoveryVisitor.java
TestNewPlanImplicitSplit.java
TestPigServerWithMacros.java
TestRegisteredJarVisibility.java
TestStoreInstances.java
TestToolsPigServer.java

Also turn off opt.fetch for tez tests as some tests were passing because of that without running
on Tez.


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/pig/branches/tez/build.xml 1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/shims/test/hadoop23/org/apache/pig/test/TezMiniCluster.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigInputFormat.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/POFRJoinTez.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/POStoreTez.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/PigProcessor.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezJobControlCompiler.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/util/CombinerOptimizerUtil.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/impl/PigContext.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/impl/util/UDFContext.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestFRJoin.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestFRJoin2.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestFRJoinNullValue.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestGrunt.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestImplicitSplit.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestInputOutputMiniClusterFileValidator.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestJoin.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestJoinSmoke.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestKeyTypeDiscoveryVisitor.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestNewPlanImplicitSplit.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPigContext.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPigServerWithMacros.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPigStorage.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPoissonSampleLoader.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestRegisteredJarVisibility.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestStoreInstances.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestToolsPigServer.java
1595252 
  http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/Util.java 1595252

  http://svn.apache.org/repos/asf/pig/branches/tez/test/tez-tests 1595252 

Diff: https://reviews.apache.org/r/21405/diff/


Testing
-------

Unit tests are fine. Running full e2e now.


Thanks,

Rohini Palaniswamy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message