Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5AEA910D5E for ; Thu, 23 Jan 2014 15:51:08 +0000 (UTC) Received: (qmail 66249 invoked by uid 500); 23 Jan 2014 15:51:07 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 66154 invoked by uid 500); 23 Jan 2014 15:51:06 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 66140 invoked by uid 99); 23 Jan 2014 15:51:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jan 2014 15:51:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 51F731C0480; Thu, 23 Jan 2014 15:51:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6229786638345082811==" MIME-Version: 1.0 Subject: Review Request 17240: PIG-3717 AvroStorage is not filtering hidden files on directory recursion From: "Jarek Cecho" To: "pig" , "Jarek Cecho" Date: Thu, 23 Jan 2014 15:51:04 -0000 Message-ID: <20140123155104.3932.84250@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jarek Cecho" X-ReviewGroup: pig X-ReviewRequest-URL: https://reviews.apache.org/r/17240/ X-Sender: "Jarek Cecho" Reply-To: "Jarek Cecho" X-ReviewRequest-Repository: pig-git --===============6229786638345082811== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17240/ ----------------------------------------------------------- Review request for pig. Bugs: PIG-3717 https://issues.apache.org/jira/browse/PIG-3717 Repository: pig-git Description ------- We do have PATH_FILTER correctly defined to filter out hidden files, but it's used only during recursion entry point. When doing directory listing inside the recursion, we did not used the filter. I've added the filter there. Diffs ----- contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 7235ab8df32a902dfb9b90622e02f16c10f6a6e4 contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorageUtils.java 99bc43eb83fbf272806dc7cca66c904bcbf71577 Diff: https://reviews.apache.org/r/17240/diff/ Testing ------- Added new test case covering this issue. Thanks, Jarek Cecho --===============6229786638345082811==--