pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-3456) Reduce threadlocal conf access in backend for each record
Date Thu, 30 Jan 2014 21:38:20 GMT

    [ https://issues.apache.org/jira/browse/PIG-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887098#comment-13887098
] 

Dmitriy V. Ryaboy commented on PIG-3456:
----------------------------------------

Could you post a patch without the whitespace changes (for ease of review) and some microbenchmark
results?

I had some microbenchmark code in PIG-3325, that might help bootstrap you here.

> Reduce threadlocal conf access in backend for each record
> ---------------------------------------------------------
>
>                 Key: PIG-3456
>                 URL: https://issues.apache.org/jira/browse/PIG-3456
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.11.1
>            Reporter: Rohini Palaniswamy
>            Assignee: Rohini Palaniswamy
>             Fix For: 0.13.0
>
>         Attachments: PIG-3456-1.patch
>
>
> Noticed few things while browsing code
> 1) DefaultTuple has a protected boolean isNull = false; which is never used. Removing
this gives ~3-5% improvement for big jobs
> 2) Config checking with ThreadLocal conf is repeatedly done for each record. For eg:
createDataBag in POCombinerPackage. But initialized only for first time in other places like
POPackage, POJoinPackage, etc.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message