pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai" <dai...@gmail.com>
Subject Re: Review Request 17087: PIG-2207 Support custom counters for aggregating warnings from different udfs
Date Wed, 22 Jan 2014 23:43:13 GMT


> On Jan. 22, 2014, 9:43 p.m., Daniel Dai wrote:
> > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java,
line 68
> > <https://reviews.apache.org/r/17087/diff/1/?file=429825#file429825line68>
> >
> >     New LoadFunc/StoreFunc might use it, right?
> 
> Aniket Mokashi wrote:
>     I mean, LoadFunc/StoreFunc does not currently use PigHadoopLogger. We can do another
jira to fix that.
> 
> Daniel Dai wrote:
>     What I mean is if tomorrow a LoadFunc decide to use counter, if he choose to use
PigHadoopLogger.warn, should it behave the same as EvalFunc?
> 
> Aniket Mokashi wrote:
>     So, your point is since its a singleton, its possible for LoadFunc's to PigHadoopLogger.getInstance().warn
and make use of this api. I agree to your point, let me add this to the code.
>     
>     By the way, LoadFunc has "public final void warn(String msg, Enum warningEnum)" that
does report aggregated warnings but not through this api. I'm not sure why we did not use
this api. Any thoughts?

Not sure why, but make EvalFunc standout seems not right to me in your method.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17087/#review32558
-----------------------------------------------------------


On Jan. 22, 2014, 7:24 p.m., Aniket Mokashi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17087/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 7:24 p.m.)
> 
> 
> Review request for pig, Cheolsoo Park, Daniel Dai, and Thejas Nair.
> 
> 
> Bugs: PIG-2207
>     https://issues.apache.org/jira/browse/PIG-2207
> 
> 
> Repository: pig-git
> 
> 
> Description
> -------
> 
> - Grouped counters for udfs
> - Log at least once.
> 
> 
> Diffs
> -----
> 
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java
6842b10 
> 
> Diff: https://reviews.apache.org/r/17087/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aniket Mokashi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message