pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-3568) Define the semantics of POStatus.STATUS_NULL
Date Fri, 15 Nov 2013 06:07:25 GMT

    [ https://issues.apache.org/jira/browse/PIG-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823333#comment-13823333
] 

Cheolsoo Park commented on PIG-3568:
------------------------------------

Thank you for cleaning up this mess!

The patch looks good to me. I am running unit and e2e tests now.

> Define the semantics of POStatus.STATUS_NULL
> --------------------------------------------
>
>                 Key: PIG-3568
>                 URL: https://issues.apache.org/jira/browse/PIG-3568
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Mark Wagner
>            Assignee: Mark Wagner
>         Attachments: PIG-3568.1.patch
>
>
> The meaning of POStatus.STATUS_NULL is not well documented and there are conflicting
view points on its interpretation. The two interpretations are:
> 1. POStatus.STATUS_NULL indicates that the pulled output IS null. This is mostly found
in expression operators, particularly comparison operators.
> 2. POStatus.STATUS_NULL indicates that the pull did not produce any output. This is backed
up by its usage in POPackage (not JoinPackage) for flattening an empty bag, and PigGenericMapBase
where pulls on the operator pipeline that result in STATUS_NULL are discarded.
> I propose that 2 should be the official definition going forward. The first meaning is
easily indicated by (null, STATUS_OK) and all the relational operators already seem to follow
2. I'd like to hear others' opinions as well though.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message