Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 789EE10528 for ; Tue, 22 Oct 2013 05:28:06 +0000 (UTC) Received: (qmail 72758 invoked by uid 500); 22 Oct 2013 05:28:04 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 72340 invoked by uid 500); 22 Oct 2013 05:27:57 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 72327 invoked by uid 99); 22 Oct 2013 05:27:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 05:27:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D985B1D3668; Tue, 22 Oct 2013 05:27:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5480896536336005521==" MIME-Version: 1.0 Subject: Re: Review Request 14775: PIG-3325 Adding a tuple to a bag is slow From: "Cheolsoo Park" To: "Julien Le Dem" , "Mark Wagner" , "Dmitriy Ryaboy" , "Cheolsoo Park" Cc: "Aniket Mokashi" , "pig" Date: Tue, 22 Oct 2013 05:27:50 -0000 Message-ID: <20131022052750.25434.68838@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Cheolsoo Park" X-ReviewGroup: pig X-ReviewRequest-URL: https://reviews.apache.org/r/14775/ X-Sender: "Cheolsoo Park" References: <20131021025355.25435.3111@reviews.apache.org> In-Reply-To: <20131021025355.25435.3111@reviews.apache.org> Reply-To: "Cheolsoo Park" --===============5480896536336005521== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14775/#review27277 ----------------------------------------------------------- Ship it! LGTM! Thank you Aniket! - Cheolsoo Park On Oct. 21, 2013, 2:53 a.m., Aniket Mokashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14775/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 2:53 a.m.) > > > Review request for pig, Cheolsoo Park, Dmitriy Ryaboy, Julien Le Dem, and Mark Wagner. > > > Bugs: PIG-3325 > https://issues.apache.org/jira/browse/PIG-3325 > > > Repository: pig > > > Description > ------- > > Adding a tuple to a bag is slow > - Fixed issue with sampling and minor edits in comments. > > > Diffs > ----- > > trunk/src/org/apache/pig/data/DefaultAbstractBag.java 1531787 > > Diff: https://reviews.apache.org/r/14775/diff/ > > > Testing > ------- > > test-commit, TestDataBag, TestDataBagAccess pass. > > > Thanks, > > Aniket Mokashi > > --===============5480896536336005521==--