Return-Path: 
 <dev-return-37259-apmail-pig-dev-archive=pig.apache.org@pig.apache.org>
X-Original-To: apmail-pig-dev-archive@www.apache.org
Delivered-To: apmail-pig-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 95ABA108A3
	for <apmail-pig-dev-archive@www.apache.org>;
 Thu,  1 Aug 2013 00:30:29 +0000 (UTC)
Received: (qmail 84323 invoked by uid 500); 1 Aug 2013 00:30:29 -0000
Delivered-To: apmail-pig-dev-archive@pig.apache.org
Received: (qmail 84253 invoked by uid 500); 1 Aug 2013 00:30:29 -0000
Mailing-List: contact dev-help@pig.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@pig.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@pig.apache.org>
List-Post: <mailto:dev@pig.apache.org>
List-Id: <dev.pig.apache.org>
Reply-To: dev@pig.apache.org
Delivered-To: mailing list dev@pig.apache.org
Received: (qmail 84236 invoked by uid 99); 1 Aug 2013 00:30:29 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2013 00:30:29 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id D88CA1D135B;
	Thu,  1 Aug 2013 00:30:27 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5642943498311984395=="
MIME-Version: 1.0
Subject: Re: Review Request 13122: PIG-3400 FS commands do not work with S3
 paths
From: "Cheolsoo Park" <piaozhexiu@gmail.com>
To: "Rohini Palaniswamy" <rohini.aditya@gmail.com>,
 "pig" <dev@pig.apache.org>,
 "Cheolsoo Park" <piaozhexiu@gmail.com>
Date: Thu, 01 Aug 2013 00:30:27 -0000
Message-ID: <20130801003027.6985.54962@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Cheolsoo Park" <noreply@reviews.apache.org>
X-ReviewGroup: pig
X-ReviewRequest-URL: https://reviews.apache.org/r/13122/
X-Sender: "Cheolsoo Park" <noreply@reviews.apache.org>
References: <20130731220746.6985.69975@reviews.apache.org>
In-Reply-To: <20130731220746.6985.69975@reviews.apache.org>
Reply-To: "Cheolsoo Park" <piaozhexiu@gmail.com>

--===============5642943498311984395==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit



> On July 31, 2013, 10:07 p.m., Rohini Palaniswamy wrote:
> > http://pig.apache.org/docs/r0.11.1/cmds.html
> > 
> >   The fs commands should be documented as part of http://pig.apache.org/docs/r0.11.1/cmds.html#fs and not http://pig.apache.org/docs/r0.11.1/cmds.html#utillity-cmds. Utility cmds are grunt commands.

Actually, no. The commands that I am fixing are different from "fs" commands. It's confusing, but both of the following work as of now:

grunt> fs ls <path>
grunt> ls <path>


- Cheolsoo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13122/#review24376
-----------------------------------------------------------


On July 31, 2013, 7:37 p.m., Cheolsoo Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13122/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 7:37 p.m.)
> 
> 
> Review request for pig.
> 
> 
> Bugs: PIG-3400
>     https://issues.apache.org/jira/browse/PIG-3400
> 
> 
> Repository: pig-git
> 
> 
> Description
> -------
> 
> Makes fs utility commands work with s3 paths. Documents fs utility commands in the Pig manual. (They were not documented at all.)
> 
> 
> Diffs
> -----
> 
>   src/docs/src/documentation/content/xdocs/cmds.xml 38babd2 
>   src/org/apache/pig/tools/grunt/GruntParser.java c785084 
> 
> Diff: https://reviews.apache.org/r/13122/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> 
> Manually verified the following commands with s3 paths:
> pig -e 'ls s3://<path>'
> pig -e 'mkdir s3://<path>'
> pig -e 'rm s3://<path>'
> pig -e 'cp s3://<path1> s3://<path2>'
> pig -e 'mv s3://<path1> s3://<path2>'
> pig -e 'copyToLocal s3://<path>/<file> .'
> pig -e 'copyFromLocal <file> s3://<path>' 
> 
> 
> Thanks,
> 
> Cheolsoo Park
> 
>


--===============5642943498311984395==--