pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-3414) QueryParserDriver.parseSchema(String) silently returns a wrong result when a comma is missing in the schema definition
Date Fri, 09 Aug 2013 21:28:47 GMT

     [ https://issues.apache.org/jira/browse/PIG-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Cheolsoo Park updated PIG-3414:
-------------------------------

    Attachment: PIG-3414-2.patch

OK, here is a new patch that fixes the grammar. I added a new rule as follows:
{code}
standalone_field_def_list: field_def_list EOF;
{code}
As can be seen, this rule will ensure that all the tokens are consumed. Let me know if you
have a better suggestion.
                
> QueryParserDriver.parseSchema(String) silently returns a wrong result when a comma is
missing in the schema definition
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-3414
>                 URL: https://issues.apache.org/jira/browse/PIG-3414
>             Project: Pig
>          Issue Type: Bug
>          Components: parser
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>             Fix For: 0.12
>
>         Attachments: PIG-3414-2.patch, PIG-3414.patch
>
>
> QueryParserDriver provides a convenient method to parse from string to LogicalSchema.
But if a comma is missing between two fields in the schema definition, it silently returns
a wrong result. For example,
> {code}
> a:int b:long
> {code}
> This string will be parsed up to "a:int", and "b:long" will be silently discarded. This
should rather fail with a parser exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message