pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-3374) CASE and IN fail when expression includes dereferencing operator
Date Sat, 06 Jul 2013 01:05:48 GMT

     [ https://issues.apache.org/jira/browse/PIG-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Cheolsoo Park updated PIG-3374:
-------------------------------

    Attachment: PIG-3374.patch

ReviewBoard:
https://reviews.apache.org/r/12290/
                
> CASE and IN fail when expression includes dereferencing operator
> ----------------------------------------------------------------
>
>                 Key: PIG-3374
>                 URL: https://issues.apache.org/jira/browse/PIG-3374
>             Project: Pig
>          Issue Type: Bug
>          Components: parser
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>             Fix For: 0.12
>
>         Attachments: PIG-3374.patch
>
>
> This is another bug that I discovered after deploying CASE/IN expressions internally.
> The current implementation of CASE/IN expression assumes that the 1st operand is a single
expression. But this is not true, for example, if it contains a dereferencing operator. The
following example demonstrates the problem:
> {code}
> A = LOAD 'foo' AS (k1:chararray, k2:chararray, v:int);
> B = GROUP A BY (k1, k2);
> C = FILTER B BY group.k1 IN ('a', 'b');
> DUMP C;
> {code}
> This fails with the following error:
> {code}
> Caused by: java.lang.IndexOutOfBoundsException: Index: 5, Size: 5
>     at java.util.ArrayList.RangeCheck(ArrayList.java:547)
>     at java.util.ArrayList.get(ArrayList.java:322)
>     at org.apache.pig.parser.LogicalPlanGenerator.in_eval(LogicalPlanGenerator.java:8624)
>     at org.apache.pig.parser.LogicalPlanGenerator.cond(LogicalPlanGenerator.java:8405)
>     at org.apache.pig.parser.LogicalPlanGenerator.filter_clause(LogicalPlanGenerator.java:7564)
>     at org.apache.pig.parser.LogicalPlanGenerator.op_clause(LogicalPlanGenerator.java:1403)
>     at org.apache.pig.parser.LogicalPlanGenerator.general_statement(LogicalPlanGenerator.java:821)
>     at org.apache.pig.parser.LogicalPlanGenerator.statement(LogicalPlanGenerator.java:539)
>     at org.apache.pig.parser.LogicalPlanGenerator.query(LogicalPlanGenerator.java:414)
>     at org.apache.pig.parser.QueryParserDriver.parse(QueryParserDriver.java:181)
> {code}
> Here is the relavant code that causes trouble:
> {code:title=QueryParser.g}
> if(tree.getType() == IN) {
>   Tree lhs = tree.getChild(0); // lhs is not a single node!
>   for(int i = 2; i < tree.getChildCount(); i = i + 2) {
>     tree.insertChild(i, deepCopy(lhs));
>   }
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message