Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24C46C98C for ; Tue, 11 Jun 2013 15:55:46 +0000 (UTC) Received: (qmail 59959 invoked by uid 500); 11 Jun 2013 15:55:46 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 59556 invoked by uid 500); 11 Jun 2013 15:55:40 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 59512 invoked by uid 99); 11 Jun 2013 15:55:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 15:55:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9BB931CA71D; Tue, 11 Jun 2013 15:55:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1988561114242068140==" MIME-Version: 1.0 Subject: Re: Review Request: PIG-3318 Patch to address default values when schemas are merged in AvroStorage. It does this for Records containing primitive values From: "Rohini Palaniswamy" To: "Rohini Palaniswamy" Cc: "Viraj Bhat" , "pig" Date: Tue, 11 Jun 2013 15:55:31 -0000 Message-ID: <20130611155531.3611.52953@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohini Palaniswamy" X-ReviewGroup: pig X-ReviewRequest-URL: https://reviews.apache.org/r/11135/ X-Sender: "Rohini Palaniswamy" References: <20130611030416.3558.48656@reviews.apache.org> In-Reply-To: <20130611030416.3558.48656@reviews.apache.org> Reply-To: "Rohini Palaniswamy" --===============1988561114242068140== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11135/#review21704 ----------------------------------------------------------- http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/j= ava/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java Should be outside if else http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/j= ava/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java Do not need this variable. Can do if else on the condition http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/j= ava/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java formatting. space after , http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/j= ava/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java formatting. Code in next line - Rohini Palaniswamy On June 11, 2013, 3:04 a.m., Viraj Bhat wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11135/ > ----------------------------------------------------------- > = > (Updated June 11, 2013, 3:04 a.m.) > = > = > Review request for pig and Rohini Palaniswamy. > = > = > Description > ------- > = > Default values are not honoured when merging default schema > = > = > This addresses bug PIG-3318. > https://issues.apache.org/jira/browse/PIG-3318 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/ma= in/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556 = > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/ma= in/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556 = > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/ma= in/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491= 556 = > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/te= st/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 149= 1562 = > = > Diff: https://reviews.apache.org/r/11135/diff/ > = > = > Testing > ------- > = > Yes > = > = > Thanks, > = > Viraj Bhat > = > --===============1988561114242068140==--