pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cheolsoo Park <piaozhe...@gmail.com>
Subject Re: Uploading patches for review
Date Thu, 06 Jun 2013 06:53:46 GMT
I agree that we should use the RB more often.


On Wed, Jun 5, 2013 at 6:50 PM, Jarek Jarcec Cecho <jarcec@apache.org>wrote:

> I can definitely recommend using the review board. We are using it already
> in all other projects that I'm participating and it's really helping us out.
>
> Jarcec
>
> On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
> > Hi,
> >     Reviewing uploaded patches for few lines of change is easy. But when
> > the change is more it is hard to read, review is more time consuming and
> at
> > times you have to switch between the patch and eclipse to get more
> context.
> > Without the surrounding code it is also easy to miss things on review.
> Can
> > we make it a practice and decide on putting up the patches in review
> board
> > for review if it is slightly bigger? Commenting on the patch is also a
> > breeze in the review board.
> >
> > Thoughts ???
> >
> > Regards,
> > Rohini
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message