pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Viraj Bhat" <vi...@yahoo-inc.com>
Subject Re: Review Request: PIG-3318 Patch to address default values when schemas are merged in AvroStorage. It does this for Records containing primitive values
Date Thu, 13 Jun 2013 18:34:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------

(Updated June 13, 2013, 6:34 p.m.)


Review request for pig and Rohini Palaniswamy.


Changes
-------

1) Change the testcase to use mockstorage
2) Remove the condition that does not verify results in Hadoop 23
3) Add back the "usemultipleSchemas" flag to handle cases when schemaToMergedSchemaMap is
null and multiple_schemas is invoked. Test case testMultipleSchema1 fails for the previous
patch
4) Testing done with Hadoop 23


Description
-------

Default values are not honoured when merging default schema


This addresses bug PIG-3318.
    https://issues.apache.org/jira/browse/PIG-3318


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java
1491556 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
1491556 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java
1491556 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
1491556 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java
1491562 

Diff: https://reviews.apache.org/r/11135/diff/


Testing
-------

Yes


Thanks,

Viraj Bhat


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message