pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-3122) Operators should not implicitly become reserved keywords
Date Sat, 13 Apr 2013 18:22:15 GMT

    [ https://issues.apache.org/jira/browse/PIG-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631114#comment-13631114
] 

Cheolsoo Park commented on PIG-3122:
------------------------------------

All unit tests pass.
                
> Operators should not implicitly become reserved keywords
> --------------------------------------------------------
>
>                 Key: PIG-3122
>                 URL: https://issues.apache.org/jira/browse/PIG-3122
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.12
>
>         Attachments: PIG-3122-0.patch, PIG-3122-1.patch, PIG-3122-2.patch, PIG-3122-3.patch
>
>
> As a byproduct of how ANTLR lexes things, whenever we introduce a new operator (RANK,
CUBE, and any special keyword really) we are implicitly introducing a reserved word that can't
be used for relations, columns, etc (unless give to us by the framework, as in the case of
group).
> The following, for example, fails:
> {code}
> a = load 'foo' as (x:int);
> a = foreach a generate x as rank;
> {code}
> I'll include a patch to fix this essentially by whitelisting tokens. I currently just
whitelist cube, rank, and group. We can add more as people want them? Can anyone think of
reasonable ones they'd like to add?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message