pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-3253) Misleading comment w.r.t getSplitIndex() method in PigSplit.java
Date Wed, 20 Mar 2013 21:13:16 GMT

     [ https://issues.apache.org/jira/browse/PIG-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Cheolsoo Park updated PIG-3253:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.12
           Status: Resolved  (was: Patch Available)

Committed to trunk. Thank you Daniel for the review!
                
> Misleading comment w.r.t getSplitIndex() method in PigSplit.java
> ----------------------------------------------------------------
>
>                 Key: PIG-3253
>                 URL: https://issues.apache.org/jira/browse/PIG-3253
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>            Priority: Minor
>             Fix For: 0.12
>
>         Attachments: PIG-3253.patch
>
>
> While reviewing the patch for PIG-3141, I noticed that the following comment is out-of-date:
> {code:title=PigSplit.java}
> // package level access because we don't want LoadFunc implementations
> // to get this information - this is to be used only from
> // MergeJoinIndexer
> public int getSplitIndex() {
>     return splitIndex;
> }
> {code}
> Looking at the commit history, the public qualifier was added by PIG-1309, but the comment
wasn't updated accordingly.
> Provided that more and more LoadFunc implementations use this method (e.g. PIG-3141),
we should remove this misleading comment to avoid any confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message