pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prashant Kommireddi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
Date Sun, 17 Feb 2013 02:43:13 GMT

    [ https://issues.apache.org/jira/browse/PIG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580104#comment-13580104
] 

Prashant Kommireddi commented on PIG-1420:
------------------------------------------

Also, would this change be backward compatible? I am seeing this in javadocs and am afraid
users might have their scripts written based on the following assumption.

{code}
/**
 * Generates the concatenation of the first two arguments.  It can be
 * used with two bytearrays or two chararrays (but not a mixture of the two).
 */
{code}

And the Pig docs http://pig.apache.org/docs/r0.10.0/func.html#concat
                
> Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
> -----------------------------------------------------------------------------------------
>
>                 Key: PIG-1420
>                 URL: https://issues.apache.org/jira/browse/PIG-1420
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Russell Jurney
>            Assignee: Russell Jurney
>              Labels: five, high
>             Fix For: 0.8.0
>
>         Attachments: addconcat2.patch, PIG-1420.2.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> org.apache.pig.builtin.CONCAT (which acts on DataByteArray's internally) and org.apache.pig.builtin.StringConcat
(which acts on Strings internally), both act on the first two fields of a tuple.  This results
in ugly nested CONCAT calls like:
> CONCAT(CONCAT(A, ' '), B)
> The more desirable form is:
> CONCAT(A, ' ', B)
> This change will be backwards compatible, provided that no one was relying on the fact
that CONCAT ignores fields after the first two in a tuple.  This seems a reasonable assumption
to make, or at least a small break in compatibility for a sizable improvement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message