pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner" <ghagleit...@hortonworks.com>
Subject Re: Review Request: Review for PIG-2641 - add ToJson builtin to Pig
Date Mon, 18 Feb 2013 01:21:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9481/#review16698
-----------------------------------------------------------


Looks good to me.

- Gunther Hagleitner


On Feb. 17, 2013, 9:47 p.m., Russell Jurney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9481/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 9:47 p.m.)
> 
> 
> Review request for pig, Ashutosh Chauhan, Dmitriy Ryaboy, Alan Gates, Jonathan Coveney,
and Bill Graham.
> 
> 
> Description
> -------
> 
> This patch is for JIRA, https://issues.apache.org/jira/browse/PIG-2641 PIG-2641 - which
adds a ToJson builtin based on the serialization in JsonStorage.
> 
> 
> This addresses bug PIG-2641.
>     https://issues.apache.org/jira/browse/PIG-2641
> 
> 
> Diffs
> -----
> 
>   src/org/apache/pig/builtin/JsonStorage.java 56086ff 
>   src/org/apache/pig/builtin/ToJson.java PRE-CREATION 
>   test/org/apache/pig/test/TestToJson.java PRE-CREATION 
>   test/org/apache/pig/test/data/jsonStorage1.tojson PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9481/diff/
> 
> 
> Testing
> -------
> 
> This works for me locally, and there is a working unit test.
> 
> 
> Thanks,
> 
> Russell Jurney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message