pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Coveney" <jcove...@gmail.com>
Subject Re: Review Request: Review for PIG-2641 - add ToJson builtin to Pig
Date Sun, 17 Feb 2013 01:03:58 GMT


> On Feb. 17, 2013, 1:03 a.m., Jonathan Coveney wrote:
> >

This looks useful. Have some stuff to address, but nothing too huge.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9481/#review16691
-----------------------------------------------------------


On Feb. 16, 2013, 11:56 p.m., Russell Jurney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9481/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2013, 11:56 p.m.)
> 
> 
> Review request for pig, Ashutosh Chauhan, Dmitriy Ryaboy, Alan Gates, Jonathan Coveney,
and Bill Graham.
> 
> 
> Description
> -------
> 
> This patch is for JIRA, https://issues.apache.org/jira/browse/PIG-2641 PIG-2641 - which
adds a ToJson builtin based on the serialization in JsonStorage.
> 
> 
> This addresses bug PIG-2641.
>     https://issues.apache.org/jira/browse/PIG-2641
> 
> 
> Diffs
> -----
> 
>   src/org/apache/pig/builtin/ToJson.java PRE-CREATION 
>   test/org/apache/pig/test/TestToJson.java PRE-CREATION 
>   test/org/apache/pig/test/data/jsonStorage1.tojson PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9481/diff/
> 
> 
> Testing
> -------
> 
> This works for me locally, and there is a working unit test.
> 
> 
> Thanks,
> 
> Russell Jurney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message