pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julien Le Dem (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-3098) Add another test for the self join case
Date Thu, 17 Jan 2013 22:52:12 GMT

    [ https://issues.apache.org/jira/browse/PIG-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556692#comment-13556692
] 

Julien Le Dem commented on PIG-3098:
------------------------------------

one minor comment regarding asserts:
{noformat}
  assertEquals(tuples.size(), out.size());
  for (Tuple t : out) {
    assertTrue(tuples.remove(t));
  }
  assertTrue(tuples.isEmpty());
{noformat}
if wrong it is not going to give much information.
please add a message as the first parameter with some info:
{noformat}
  assertEquals("tuple count for " + out, tuples.size(), out.size());
  for (Tuple t : out) {
    assertTrue("existence of " + t, tuples.remove(t));
  }
  assertTrue("all tuples consumed in " + tuples, tuples.isEmpty());
{noformat}


                
> Add another test for the self join case
> ---------------------------------------
>
>                 Key: PIG-3098
>                 URL: https://issues.apache.org/jira/browse/PIG-3098
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.12
>
>         Attachments: PIG-3098-0.patch
>
>
> This adds a test to TestJoin that doesn't just make sure that self joins work semantically
in the parser, but also that it pulls the right data through. Thought it'd be easier to just
make a new JIRA than to reopen PIG-3020.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message