Mailing-List: contact dev-help@pig.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pig.apache.org
Date: Thu, 8 Nov 2012 06:24:14 +0000 (UTC)
From: "Bill Graham (JIRA)" <jira@apache.org>
To: pig-dev@hadoop.apache.org
Message-ID: <723669681.85722.1352355854293.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <1989868790.9223.1331670159533.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (PIG-2582) Store size in bytes (not mbytes) in
 ResourceStatistics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/PIG-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Graham resolved PIG-2582.
------------------------------

      Resolution: Fixed
    Release Note: Committed, thanks Prashant!
    
> Store size in bytes (not mbytes) in ResourceStatistics
> ------------------------------------------------------
>
>                 Key: PIG-2582
>                 URL: https://issues.apache.org/jira/browse/PIG-2582
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Travis Crawford
>            Assignee: Prashant Kommireddi
>            Priority: Minor
>             Fix For: 0.12
>
>         Attachments: PIG-2582_1.patch, PIG-2582_2.patch, PIG-2582.patch
>
>
> In [ResourceStatistics.java|http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/ResourceStatistics.java?view=markup] we see mBytes is public, and has a public getter/setter.
> {code}
> 47	    public Long mBytes; // size in megabytes
> 196	    public Long getmBytes() {
> 197	        return mBytes;
> 198	    }
> 199	    public ResourceStatistics setmBytes(Long mBytes) {
> 200	        this.mBytes = mBytes;
> 201	        return this;
> 202	    }
> {code}
> Typically sizes are stored as bytes, potentially having convenience functions to return with different units.
> If mBytes can be marked private without causing woes it might be worth storing size as bytes instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira