pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Coveney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-3006) Modernize a chunk of the tests
Date Tue, 06 Nov 2012 19:34:13 GMT

    [ https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491747#comment-13491747
] 

Jonathan Coveney commented on PIG-3006:
---------------------------------------

Cheolsoo,

Absolutely feel free to proceed as such. It doesn't apply completely afaik b/c a lot of the
windows patches clashed (Daniel alerted me to this but I said for them to go ahead and that
we would fix it). So go ahead and fix and we're good to go.
                
> Modernize a chunk of the tests
> ------------------------------
>
>                 Key: PIG-3006
>                 URL: https://issues.apache.org/jira/browse/PIG-3006
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.12
>
>         Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch, PIG-3006-3.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a couple
ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where
is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it
with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message