pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: PIG-2405: some unit test case failed with open JDK
Date Wed, 07 Nov 2012 21:00:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/#review13222
-----------------------------------------------------------

Ship it!


Looks good. Thanks Fangfang!

- Cheolsoo Park


On Nov. 7, 2012, 10:55 a.m., Fang Fang Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7898/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 10:55 a.m.)
> 
> 
> Review request for pig.
> 
> 
> Description
> -------
> 
> For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn
> 
> 
> This addresses bug PIG-2405.
>     https://issues.apache.org/jira/browse/PIG-2405
> 
> 
> Diffs
> -----
> 
>   trunk/test/org/apache/pig/test/TestDataModel.java 1406517 
>   trunk/test/org/apache/pig/test/TestMRCompiler.java 1406517 
>   trunk/test/org/apache/pig/test/TestPruneColumn.java 1406517 
>   trunk/test/org/apache/pig/test/utils/TestHelper.java 1406517 
> 
> Diff: https://reviews.apache.org/r/7898/diff/
> 
> 
> Testing
> -------
> 
> The 3 UTs passed in both sun and opensource JDK.
> test-commit passed.
> test-patch failed, but the failure isn't introduced by the patch. There are [javadoc]
38 warnings in original trunk branch.[PIG-3033]
> [exec] -1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 12 new or modified tests.
> [exec]
> [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler
warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the total number of release
audit warnings.
> 
> 
> Thanks,
> 
> Fang Fang Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message