pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2881) Add SUBTRACT eval function
Date Wed, 31 Oct 2012 17:21:56 GMT

    [ https://issues.apache.org/jira/browse/PIG-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487984#comment-13487984
] 

Cheolsoo Park commented on PIG-2881:
------------------------------------

Hi Joel,

+1.

Thanks you so much for your patience. The patch looks great! All tests pass too.

I have a super minor comment on the doc. I think that the functions in the doc are listed
in alphabetical order, but your SUBTRACT comes before IsEmpty. I guess that you added it there
because SUBTRACT is similar to DIFF? Would it make more sense to follow the order? If you
could upload a new patch that fixes the order, that would be great.

Thanks!

p.s. You don't have to clean old attached files. In fact, it's better to keep them since they
show how this jira has developed and make it easier for others to understand history. :-)
                
> Add SUBTRACT eval function
> --------------------------
>
>                 Key: PIG-2881
>                 URL: https://issues.apache.org/jira/browse/PIG-2881
>             Project: Pig
>          Issue Type: New Feature
>          Components: piggybank
>    Affects Versions: 0.10.0
>            Reporter: Joel Costigliola
>            Priority: Minor
>         Attachments: PIG-2881.patch
>
>
> Close to DIFF function but SUBTRACT(bag1, bag2) will subtract elements of bag2 from bag1.
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message