pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prashant Kommireddi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2582) Store size in bytes (not mbytes) in ResourceStatistics
Date Thu, 18 Oct 2012 17:48:03 GMT

    [ https://issues.apache.org/jira/browse/PIG-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479181#comment-13479181
] 

Prashant Kommireddi commented on PIG-2582:
------------------------------------------

I agree on storing size in bytes, just wanted to make sure I understand all the reasons you
had in mind. It wouldn't be a huge change to make it happen, but changing the scope might
be tricky if someone is using it outside of the Pig project. What do you think about marking
the setter "setmBytes(Long)" deprecated and creating a new setter for bytes? To start with,
we can atleast have Pig refer to byte-based methods.
                
> Store size in bytes (not mbytes) in ResourceStatistics
> ------------------------------------------------------
>
>                 Key: PIG-2582
>                 URL: https://issues.apache.org/jira/browse/PIG-2582
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Travis Crawford
>            Priority: Minor
>
> In [ResourceStatistics.java|http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/ResourceStatistics.java?view=markup]
we see mBytes is public, and has a public getter/setter.
> {code}
> 47	    public Long mBytes; // size in megabytes
> 196	    public Long getmBytes() {
> 197	        return mBytes;
> 198	    }
> 199	    public ResourceStatistics setmBytes(Long mBytes) {
> 200	        this.mBytes = mBytes;
> 201	        return this;
> 202	    }
> {code}
> Typically sizes are stored as bytes, potentially having convenience functions to return
with different units.
> If mBytes can be marked private without causing woes it might be worth storing size as
bytes instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message