pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Gordon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2943) DevTests, Refactor Windows checks to use new Util.WINDOWS method for code health
Date Wed, 17 Oct 2012 01:44:03 GMT

    [ https://issues.apache.org/jira/browse/PIG-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477528#comment-13477528
] 

John Gordon commented on PIG-2943:
----------------------------------

Thank you!  Sorry about that.
                
> DevTests, Refactor Windows checks to use new Util.WINDOWS method for code health
> --------------------------------------------------------------------------------
>
>                 Key: PIG-2943
>                 URL: https://issues.apache.org/jira/browse/PIG-2943
>             Project: Pig
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.10.0
>            Reporter: John Gordon
>            Assignee: John Gordon
>             Fix For: 0.11
>
>         Attachments: 0004-One-off-for-testParamSubPreproc.patch, 0005-One-off-for-TypeCheckingValidator.patch
>
>
> SOme tests still look for Windows via a search of the OS string.  Since we have a utility
function, now, it makes sense to refactor all of those to use that function.  That way, if
we ever need to change the logic there is only one place to worry about it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message