Return-Path: 
 <dev-return-30601-apmail-pig-dev-archive=pig.apache.org@pig.apache.org>
X-Original-To: apmail-pig-dev-archive@www.apache.org
Delivered-To: apmail-pig-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D8F02D7DD
	for <apmail-pig-dev-archive@www.apache.org>;
 Mon,  3 Sep 2012 09:30:10 +0000 (UTC)
Received: (qmail 70503 invoked by uid 500); 3 Sep 2012 09:30:10 -0000
Delivered-To: apmail-pig-dev-archive@pig.apache.org
Received: (qmail 69933 invoked by uid 500); 3 Sep 2012 09:30:09 -0000
Mailing-List: contact dev-help@pig.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@pig.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@pig.apache.org>
List-Post: <mailto:dev@pig.apache.org>
List-Id: <dev.pig.apache.org>
Reply-To: dev@pig.apache.org
Delivered-To: mailing list dev@pig.apache.org
Received: (qmail 69520 invoked by uid 500); 3 Sep 2012 09:30:07 -0000
Delivered-To: apmail-hadoop-pig-dev@hadoop.apache.org
Received: (qmail 69505 invoked by uid 99); 3 Sep 2012 09:30:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2012 09:30:07 +0000
Date: Mon, 3 Sep 2012 20:30:07 +1100 (NCT)
From: "Gianmarco De Francisci Morales (JIRA)" <jira@apache.org>
To: pig-dev@hadoop.apache.org
Message-ID: <971695514.29795.1346664607765.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <963062254.27004.1321286991680.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (PIG-2362) Rework Ant build.xml to use macrodef
 instead of antcall
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/PIG-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447179#comment-13447179 ] 

Gianmarco De Francisci Morales commented on PIG-2362:
-----------------------------------------------------

Too bad we didn't manage to mavenize Pig.
Yes, I will take another crack at it later this week.
                
> Rework Ant build.xml to use macrodef instead of antcall
> -------------------------------------------------------
>
>                 Key: PIG-2362
>                 URL: https://issues.apache.org/jira/browse/PIG-2362
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>            Priority: Minor
>             Fix For: 0.11
>
>         Attachments: PIG-2362.1.patch, PIG-2362.2.patch, PIG-2362.3.patch, PIG-2362.4.patch, PIG-2362.5.patch
>
>
> Antcall is evil: http://www.build-doctor.com/2008/03/13/antcall-is-evil/
> We'd better use macrodef and let Ant build a clean dependency graph.
> http://ant.apache.org/manual/Tasks/macrodef.html
> Right now we do like this:
> {code}
> <target name="buildAllJars">
>   <antcall target="buildJar">
>     <param name="build.dir" value="jar-A"/>
>   </antcall>
>   <antcall target="buildJar">
>     <param name="build.dir" value="jar-B"/>
>   </antcall>
>   <antcall target="buildJar">
>     <param name="build.dir" value="jar-C"/>
>   </antcall>
> </target>
> <target name="buildJar">
>   <jar destfile="target/${build.dir}.jar" basedir="${build.dir}/classfiles"/>
> </target>
> {code}
> But it would be better if we did like this:
> {code}
> <target name="buildAllJars">
>   <buildJar build.dir="jar-A"/>
>   <buildJar build.dir="jar-B"/>
>   <buildJar build.dir="jar-C"/>
> </target>
> <macrodef name="buildJar">
>   <attribute name="build.dir"/>
>   <jar destfile="target/${build.dir}.jar" basedir="${build.dir}/classfiles"/>
> </macrodef>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira