pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-1166) A bit change of the interface of Tuple & DataBag ( make the set and append method return this)
Date Sun, 02 Sep 2012 23:19:07 GMT

     [ https://issues.apache.org/jira/browse/PIG-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dmitriy V. Ryaboy updated PIG-1166:
-----------------------------------

    Resolution: Won't Fix
        Status: Resolved  (was: Patch Available)
    
> A bit change of the interface of Tuple & DataBag ( make the set and append method
return this)
> ----------------------------------------------------------------------------------------------
>
>                 Key: PIG-1166
>                 URL: https://issues.apache.org/jira/browse/PIG-1166
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>            Priority: Minor
>         Attachments: Pig_1166.patch
>
>
> When people write unit test for UDF, they always need to build a tuple or bag. If we
change the interface of Tuple and DataBag,  make the set and append method return this, it
can decrease the code size.  e.g. Now people have to write the following code to build a Tuple:
> {code}
> Tuple tuple=TupleFactory.getInstance().newTuple(3);
> tuple.set(0,"item_0");
> tuple.set(1,"item_1");
> tuple.set(2,"item_2");
> {code}
> If we change the interface,  make the set and append method return this, we can rewrite
the above code like this:
> {code}
> Tuple tuple=TupleFactory.getInstance().newTuple(3);
> tuple.set(0,"item_0").set(1,"item_1").set(2,"item_2");
> {code}
> This interface change won't have back compatibility problem and I think there's no performance
problem too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message