Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6904DD114 for ; Fri, 6 Jul 2012 06:31:37 +0000 (UTC) Received: (qmail 17158 invoked by uid 500); 6 Jul 2012 06:31:37 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 17014 invoked by uid 500); 6 Jul 2012 06:31:37 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 16986 invoked by uid 500); 6 Jul 2012 06:31:36 -0000 Delivered-To: apmail-hadoop-pig-dev@hadoop.apache.org Received: (qmail 16978 invoked by uid 99); 6 Jul 2012 06:31:35 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jul 2012 06:31:35 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id A433A142853 for ; Fri, 6 Jul 2012 06:31:35 +0000 (UTC) Date: Fri, 6 Jul 2012 06:31:35 +0000 (UTC) From: "Daniel Dai (JIRA)" To: pig-dev@hadoop.apache.org Message-ID: <595006835.12882.1341556295675.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1737144278.2103.1339396603924.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Reopened] (PIG-2746) Pig doesn't detect all forms of compression extensions properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PIG-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reopened PIG-2746: ----------------------------- The patch break TestBZip.testBz2. See PIG-2391. Revert the patch temporarily until we have a new patch. > Pig doesn't detect all forms of compression extensions properly > --------------------------------------------------------------- > > Key: PIG-2746 > URL: https://issues.apache.org/jira/browse/PIG-2746 > Project: Pig > Issue Type: Bug > Affects Versions: 0.8.1 > Reporter: Harsh J > Assignee: Harsh J > Fix For: 0.11 > > Attachments: PIG-2746.patch, PIG-2746.patch, PIG-2746.patch > > > The PigStorage has the following snippet. > {code} > private void setCompression(Path path, Job job) { > String location=path.getName(); > if (location.endsWith(".bz2") || location.endsWith(".bz")) { > FileOutputFormat.setCompressOutput(job, true); > FileOutputFormat.setOutputCompressorClass(job, BZip2Codec.class); > } else if (location.endsWith(".gz")) { > FileOutputFormat.setCompressOutput(job, true); > FileOutputFormat.setOutputCompressorClass(job, GzipCodec.class); > } else { > FileOutputFormat.setCompressOutput( job, false); > } > } > {code} > This limits it to only work with STORE filenames provided as 'output.gz' or 'output.bz2' and for the rest (like LZO) one has to specify codecs and manually enable compression. > Ideally Pig can rely on Hadoop's extension-to-codec detector instead of having this ladder. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira