Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 11BDC9A55 for ; Sun, 15 Jul 2012 02:51:55 +0000 (UTC) Received: (qmail 66623 invoked by uid 500); 15 Jul 2012 02:51:55 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 66580 invoked by uid 500); 15 Jul 2012 02:51:55 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 66535 invoked by uid 99); 15 Jul 2012 02:51:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jul 2012 02:51:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 734871C0238; Sun, 15 Jul 2012 02:51:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1919389697436238656==" MIME-Version: 1.0 Subject: Review Request: PIG-2492 AvroStorage should recognize globs and commas From: "Cheolsoo Park" To: "pig" , "Cheolsoo Park" Date: Sun, 15 Jul 2012 02:51:52 -0000 Message-ID: <20120715025152.729.62589@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Cheolsoo Park" X-ReviewGroup: pig X-ReviewRequest-URL: https://reviews.apache.org/r/5936/ X-Sender: "Cheolsoo Park" Reply-To: "Cheolsoo Park" --===============1919389697436238656== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5936/ ----------------------------------------------------------- Review request for pig. Description ------- Add glob support to AvroStorage: https://issues.apache.org/jira/browse/PIG-2492 This addresses bug PIG-2492. https://issues.apache.org/jira/browse/PIG-2492 Diffs ----- contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avr= o/AvroStorage.java 0f8ef27 = contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avr= o/AvroStorageUtils.java c7de726 = contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storag= e/avro/TestAvroStorage.java 48b093b = Diff: https://reviews.apache.org/r/5936/diff/ Testing ------- 1. Added new unit tests as follows: - testDir verifies that AvroStorage recursively loads files in a directory = and its sub-directories. - testGlob1 to 3 verify that glob patterns are expanded properly. To run the tests, please do the following: wget https://issues.apache.org/jira/secure/attachment/12536534/avro_test_fi= les.tar.gz = tar -xf avro_test_files.tar.gz ant clean compile-test piggybank -Dhadoopversion=3D20 cd contrib/piggybank/java ant test -Dtestcase=3DTestAvroStorage 2. Both TestAvroStorage and TestAvroStorageUtils pass. Thanks, Cheolsoo Park --===============1919389697436238656==--