pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Review Request: PIG-2492 AvroStorage should recognize globs and commas
Date Sun, 15 Jul 2012 02:51:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5936/
-----------------------------------------------------------

Review request for pig.


Description
-------

Add glob support to AvroStorage:

https://issues.apache.org/jira/browse/PIG-2492


This addresses bug PIG-2492.
    https://issues.apache.org/jira/browse/PIG-2492


Diffs
-----

  contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java
0f8ef27 
  contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
c7de726 
  contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java
48b093b 

Diff: https://reviews.apache.org/r/5936/diff/


Testing
-------

1. Added new unit tests as follows:

- testDir verifies that AvroStorage recursively loads files in a directory and its sub-directories.
- testGlob1 to 3 verify that glob patterns are expanded properly.

To run the tests, please do the following:

wget https://issues.apache.org/jira/secure/attachment/12536534/avro_test_files.tar.gz 
tar -xf avro_test_files.tar.gz
ant clean compile-test piggybank -Dhadoopversion=20
cd contrib/piggybank/java
ant test -Dtestcase=TestAvroStorage

2. Both TestAvroStorage and TestAvroStorageUtils pass.


Thanks,

Cheolsoo Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message