pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Coveney (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-2732) Let's get rid of the deprecated Tuple methods
Date Sun, 03 Jun 2012 03:07:23 GMT

     [ https://issues.apache.org/jira/browse/PIG-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Coveney updated PIG-2732:
----------------------------------

    Attachment: fix_CSVExcelStorage_0.patch

I've attached a fix for CSVExcelStorage. It just involved getting rid of the call to isNull(),
which is superfluous.

Side note: I've noticed that the test for IndexedStorage has been failing in piggybank (independent
of the Tuple changes). I will submit a fix separately.
                
> Let's get rid of the deprecated Tuple methods
> ---------------------------------------------
>
>                 Key: PIG-2732
>                 URL: https://issues.apache.org/jira/browse/PIG-2732
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG-2732-0.patch, fix_CSVExcelStorage_0.patch
>
>
> In my favorite comment ever, this is the comment on isNull and setNull
> {code}
>     /** 
>      * This is an unsupported method.
>      * It never really worked. Don't use it!
>      * @param isNull (but it will be ignored)
>      */
> {code}
> Simply delightful. Let's get rid of it!
> And let's @deprecate reference, which never really was used to begin with

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message