Mailing-List: contact dev-help@pig.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pig.apache.org
Date: Mon, 7 May 2012 14:10:51 +0000 (UTC)
From: "Andy Schlaikjer (JIRA)" <jira@apache.org>
To: pig-dev@hadoop.apache.org
Message-ID: 
 <680814732.34372.1336399851762.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1503952881.33270.1336373899074.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (PIG-2685) error in EvalFunc ctor when
 implementing Algebraic UDF whose return type is parameterized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PIG-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269633#comment-13269633 ] 

Andy Schlaikjer commented on PIG-2685:
--------------------------------------

The patch includes a test which fails under current build and passes with the patch to EvalFunc. Please let me know what additional tests you'd like to see here. Should I have submitted the test in a separate patch file?

                
> error in EvalFunc ctor when implementing Algebraic UDF whose return type is parameterized
> -----------------------------------------------------------------------------------------
>
>                 Key: PIG-2685
>                 URL: https://issues.apache.org/jira/browse/PIG-2685
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.10.0
>            Reporter: Andy Schlaikjer
>         Attachments: fixes_eval_func_algebraic_final_return_type_check.diff
>
>
> EvalFunc ctor uses reference equality instead of value equality when verifying return type of "final" UDF and parent Algebraic UDF are equal. This is fine in the case when both values are Class instances, but breaks when return types are ParameterizedType instances. This prohibits the creation of an Algebraic UDF whose return type is {{Map<String, Long>}}, for instance. Please see the included unit test for an example along these lines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira