pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Graham" <billgra...@gmail.com>
Subject Re: Review Request: Pig creates too many instances of Load and Store Funcs. It should be 1 in the front-end and 1 in the backend
Date Tue, 22 May 2012 04:46:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5159/#review8026
-----------------------------------------------------------

Ship it!


One minor nit, but lgtm. 


/trunk/test/org/apache/pig/test/TestMRCompiler.java
<https://reviews.apache.org/r/5159/#comment17472>

    Would be best to provide an example of what this is doing in the comments and why it's
needed.


- Bill


On 2012-05-18 00:28:32, Julien Le Dem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5159/
> -----------------------------------------------------------
> 
> (Updated 2012-05-18 00:28:32)
> 
> 
> Review request for pig.
> 
> 
> Summary
> -------
> 
> Pig creates too many instances of Load and Store Funcs. It should be 1 in the front-end
and 1 in the backend
> 
> 
> This addresses bug PIG-2699.
>     https://issues.apache.org/jira/browse/PIG-2699
> 
> 
> Diffs
> -----
> 
>   /trunk/src/org/apache/pig/PigServer.java 1339793 
>   /trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java 1339793

>   /trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java
1339793 
>   /trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStore.java
1339793 
>   /trunk/src/org/apache/pig/newplan/logical/relational/LOLoad.java 1339793 
>   /trunk/src/org/apache/pig/newplan/logical/relational/LOStore.java 1339793 
>   /trunk/src/org/apache/pig/newplan/logical/relational/LogToPhyTranslationVisitor.java
1339793 
>   /trunk/src/org/apache/pig/newplan/logical/rules/LoadStoreFuncDupSignatureValidator.java
1339793 
>   /trunk/src/org/apache/pig/newplan/logical/rules/PartitionFilterOptimizer.java 1339793

>   /trunk/src/org/apache/pig/newplan/logical/rules/TypeCastInserter.java 1339793 
>   /trunk/src/org/apache/pig/newplan/logical/visitor/ScalarVisitor.java 1339793 
>   /trunk/src/org/apache/pig/parser/FunctionType.java 1339793 
>   /trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java 1339793 
>   /trunk/src/org/apache/pig/parser/QueryParserUtils.java 1339793 
>   /trunk/test/org/apache/pig/TestLoadStoreFuncLifeCycle.java PRE-CREATION 
>   /trunk/test/org/apache/pig/parser/TestScalarVisitor.java 1339793 
>   /trunk/test/org/apache/pig/test/TestInputOutputFileValidator.java 1339793 
>   /trunk/test/org/apache/pig/test/TestLogToPhyCompiler.java 1339793 
>   /trunk/test/org/apache/pig/test/TestLogicalPlanBuilder.java 1339793 
>   /trunk/test/org/apache/pig/test/TestMRCompiler.java 1339793 
>   /trunk/test/org/apache/pig/test/TestNewPlanFilterRule.java 1339793 
>   /trunk/test/org/apache/pig/test/TestNewPlanListener.java 1339793 
>   /trunk/test/org/apache/pig/test/Util.java 1339793 
> 
> Diff: https://reviews.apache.org/r/5159/diff
> 
> 
> Testing
> -------
> 
> test-commit + new test
> 
> 
> Thanks,
> 
> Julien
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message