pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Schlaikjer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2685) error in EvalFunc ctor when implementing Algebraic UDF whose return type is parameterized
Date Mon, 07 May 2012 14:14:48 GMT

    [ https://issues.apache.org/jira/browse/PIG-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269638#comment-13269638
] 

Andy Schlaikjer commented on PIG-2685:
--------------------------------------

Strange. So the patch I uploaded; Somehow it's missing the test. I'll re-up in a minute.
                
> error in EvalFunc ctor when implementing Algebraic UDF whose return type is parameterized
> -----------------------------------------------------------------------------------------
>
>                 Key: PIG-2685
>                 URL: https://issues.apache.org/jira/browse/PIG-2685
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.10.0
>            Reporter: Andy Schlaikjer
>         Attachments: fixes_eval_func_algebraic_final_return_type_check.diff
>
>
> EvalFunc ctor uses reference equality instead of value equality when verifying return
type of "final" UDF and parent Algebraic UDF are equal. This is fine in the case when both
values are Class instances, but breaks when return types are ParameterizedType instances.
This prohibits the creation of an Algebraic UDF whose return type is {{Map<String, Long>}},
for instance. Please see the included unit test for an example along these lines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message