pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Schlaikjer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-2680) TOBAG output schema reporting
Date Thu, 03 May 2012 05:12:02 GMT

     [ https://issues.apache.org/jira/browse/PIG-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andy Schlaikjer updated PIG-2680:
---------------------------------

    Attachment: fixes_tobag_input_schema_validation.patch
    
> TOBAG output schema reporting
> -----------------------------
>
>                 Key: PIG-2680
>                 URL: https://issues.apache.org/jira/browse/PIG-2680
>             Project: Pig
>          Issue Type: Bug
>          Components: internal-udfs
>    Affects Versions: 0.10.0
>            Reporter: Andy Schlaikjer
>         Attachments: fixes_tobag_input_schema_validation.patch
>
>
> TOBAG only reports an output schema beyond {{{(NULL)}}} when all input field schemas
match deeply, including field schema aliases. This seems wrong to me. Shouldn't it just require
recursive type equality?
> For relevant code, see:
> http://svn.apache.org/viewvc/pig/tags/release-0.9.2/src/org/apache/pig/builtin/TOBAG.java?view=markup#l142
> {code:java}
>     private boolean nullEquals(Schema currentSchema, Schema newSchema) {
>         if(currentSchema == null){
>             if(newSchema != null){
>                 return false;
>             }
>             return true;
>         }
>         return currentSchema.equals(newSchema);
>     }
> {code}
> The included patch modifies the return line to use {{Schema.equals(currentSchema, newSchema,
false, true)}} to avoid alias matching requirement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message