pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott Carey <sc...@richrelevance.com>
Subject Re: Making git the repo of choice for Pig?
Date Thu, 29 Mar 2012 01:16:19 GMT
Git was built with use case #1 being Linux developers exchanging patches
as text via e-mail.  I am not sure what binary patch support Linus plans
or what it would help other than being more compact.  One disadvantage is
that it is then hard to review simple changes by simply reading the patch
itself in a text editor.  I have +1'd many near-trivial changes after only
glancing at the text of the patch.
  
SVN is (slowly) catching up to have better patch features.  'svn patch' is
now in 1.7, 1.8 will enhance it, and eventually there is planned support
for git patch extensions. In the long run the differences between the
tools for day-to-day work will shrink from where it is now.  Subversion is
planning 'svn shelve' to make it more git-like when working locally, for
example.

On 3/27/12 10:43 PM, "Dmitriy Ryaboy" <dvryaboy@gmail.com> wrote:

>Could you enumerate the problems you have with text patches?
>
>I can think of 1, but would like to hear your list.
>
>Dmitriy
>
>On Tue, Mar 27, 2012 at 2:48 PM, Russell Jurney
><russell.jurney@gmail.com> wrote:
>> Using text patches is the problem as I see it.  We should be using...
>> something else.  Doesn't git's functionality enable phasing out text
>> patches?
>>
>> On Tue, Mar 27, 2012 at 11:16 AM, Scott Carey
>><scott@richrelevance.com>wrote:
>>
>>> On the Avro project, several folk generate a patch using git and upload
>>> that to the JIRA, it patches fine using unix 'patch'.
>>> Why do you need to switch to svn to generate the patch?
>>>
>>> A committer needs to apply the patch to a location checked out with
>>>svn,
>>> but that is trivial.
>>>
>>> On 3/27/12 2:26 AM, "Gianmarco De Francisci Morales" <gdfm@apache.org>
>>> wrote:
>>>
>>> >My 2 cents, based on the S4 project experience so far (they have git)
>>>is
>>> >+1
>>> >but later.
>>> >
>>> >The process with git is still a bit fuzzy and not fully integrated and
>>> >standardized like the one with svn.
>>> >I personally use git for all my dev work with Pig, but then switch to
>>>svn
>>> >to generate the final patch. A bit cumbersome but not so bad.
>>> >
>>> >Switching now will generate confusion and is not that urgent in my
>>>humble
>>> >opinion.
>>> >
>>> >Cheers,
>>> >--
>>> >Gianmarco
>>> >
>>> >
>>> >
>>> >On Sat, Mar 24, 2012 at 01:27, Dmitriy Ryaboy <dvryaboy@gmail.com>
>>>wrote:
>>> >
>>> >> There is a check box you check when you upload a patch. If we
>>>committed
>>> >> without verifying you checked it, thats an unfortunate oversight.
>>> >>
>>> >> No, you cant send a pull request via github to apache. That's a
>>>github
>>> >> (commercial entity) feature, not a git (open source vcs) feature.
>>> >>
>>> >> Yes you can post a link on a Jira and ask people for review prior to
>>> >> submitting a formal patch.  No that's not review board or Jira
>>> >>integration.
>>> >>
>>> >>
>>> >>
>>> >> On Mar 22, 2012, at 5:59 PM, Russell Jurney
>>><russell.jurney@gmail.com>
>>> >> wrote:
>>> >>
>>> >> > That is fine.  Only committers can merge pull requests.  Not a
>>> >>problem.
>>> >> >
>>> >> > I've never signed anything, and committers take my patches.
>>>Works the
>>> >> same.
>>> >> >
>>> >> > On Thu, Mar 22, 2012 at 3:33 PM, Scott Carey
>>><scott@richrelevance.com
>>> >> >wrote:
>>> >> >
>>> >> >>
>>> >> >> There is a legal issue as well. Uploading a patch to JIRA
>>>requires
>>> >>the
>>> >> >> user to grant apache license to use the code.  A pull request
>>>from
>>> >> github
>>> >> >> does not.
>>> >> >> This is all being hashed out elsewhere, none of us here are
>>>experts.
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> On 3/22/12 2:08 PM, "Russell Jurney" <russell.jurney@gmail.com>
>>> >>wrote:
>>> >> >>
>>> >> >>> If there is already a trial going, the project would benefit
>>>from
>>> >> >>> switching
>>> >> >>> to git, as we could then (I think?) accept pull requests
on
>>>github.
>>> >>  Maybe
>>> >> >>> not, I'm not familiar with integrating multiple gits. 
Barrier
>>>of
>>> >>entry
>>> >> >>> for
>>> >> >>> contributing would then drop dramatically, making happy
for all.
>>> >> >>>
>>> >> >>> On Thu, Mar 22, 2012 at 1:58 PM, Daniel Dai
>>><daijy@hortonworks.com>
>>> >> >> wrote:
>>> >> >>>
>>> >> >>>> This can be done in the future but I don't see there
is an
>>>urgent
>>> >>need
>>> >> >>>> for that. I'd rather wait for Apache to standardize
the process
>>> >>and we
>>> >> >>>> can easily follow and switch, rather than become the
first
>>>several
>>> >>to
>>> >> >>>> try and solve the infrastructure problem.
>>> >> >>>>
>>> >> >>>> Daniel
>>> >> >>>>
>>> >> >>>> On Thu, Mar 22, 2012 at 12:02 PM, Jonathan Coveney
<
>>> >> jcoveney@gmail.com>
>>> >> >>>> wrote:
>>> >> >>>>> If people don't know git or svn, they are going
to have to
>>>learn
>>> >>one
>>> >> >>>> or
>>> >> >>>> the
>>> >> >>>>> other if they want to work with open source projects.
It
>>>might as
>>> >> >>>> well be
>>> >> >>>>> git, since that's where things are going.
>>> >> >>>>>
>>> >> >>>>> 2012/3/22 Scott Carey <scott@richrelevance.com>
>>> >> >>>>>
>>> >> >>>>>> Apache is currently doing a trial with git
as the primary
>>>repo
>>> >>using
>>> >> >>>> the
>>> >> >>>>>> CouchDB project.  Other projects may be able
to volunteer to
>>>join
>>> >> the
>>> >> >>>>>> trial, I'm not sure.
>>> >> >>>>>>
>>> >> >>>>>> see http://git-wip-us.apache.org/
>>> >> >>>>>>
>>> >> >>>>>> I suggest that if you are interested in this
join the apache
>>> >> >>>>>> infrastructure-dev list.
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>>> On 3/21/12 9:57 PM, "Russell Jurney"
>>><russell.jurney@gmail.com>
>>> >> >>>> wrote:
>>> >> >>>>>>
>>> >> >>>>>>> What's the work?
>>> >> >>>>>>>
>>> >> >>>>>>> Russell Jurney http://datasyndrome.com
>>> >> >>>>>>>
>>> >> >>>>>>> On Mar 21, 2012, at 9:39 PM, Dmitriy Ryaboy
>>><dvryaboy@gmail.com
>>> >
>>> >> >>>> wrote:
>>> >> >>>>>>>
>>> >> >>>>>>>> All that's left is for someone to volunteer
to do the work.
>>> >> >>>>>>>>
>>> >> >>>>>>>> On Mar 21, 2012, at 9:17 PM, Russell
Jurney <
>>> >> >>>> russell.jurney@gmail.com>
>>> >> >>>>>>>> wrote:
>>> >> >>>>>>>>
>>> >> >>>>>>>>> What do we have to do to be the
first real project that
>>>uses
>>> >>git?
>>> >> >>>>>>>>> Let's do that. Or, let's just sink
svn to github.
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> It will propel the project forward.
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> Russell Jurney
>>> >> >>>>>>>>> twitter.com/rjurney
>>> >> >>>>>>>>> russell.jurney@gmail.com
>>> >> >>>>>>>>> datasyndrome.com
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> On Mar 21, 2012, at 9:04 PM, Bill
Graham
>>> >><billgraham@gmail.com>
>>> >> >>>> wrote:
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>> I think this is the tweet (lacking
the entire discussion
>>>tree
>>> >> >>>> that
>>> >> >>>> we
>>> >> >>>>>>>>>> had
>>> >> >>>>>>>>>> re git) where I was pointing
out that some incubator
>>>projects
>>> >> >>>> were
>>> >> >>>>>>>>>> using
>>> >> >>>>>>>>>> git.
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> 
>>>https://twitter.com/#!/billgraham/status/174744199407738880
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> On Wed, Mar 21, 2012 at 12:47
PM, Russell Jurney
>>> >> >>>>>>>>>> <russell.jurney@gmail.com>wrote:
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>> I think this changed, and
you are now allowed.  Looking
>>>for
>>> >>the
>>> >> >>>>>>>>>>> tweets.
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> Russell Jurney http://datasyndrome.com
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> On Mar 21, 2012, at 9:36
AM, Alan Gates
>>> >><gates@hortonworks.com
>>> >> >>>
>>> >> >>>>>>>>>>> wrote:
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>> AFAIK Apache still
does not support git as a primary
>>> >> >>>> repository.
>>> >> >>>>>>>>>>>> You
>>> >> >>>>>>>>>>> can use the git mirror,
which Pig does.  If this has
>>>changed
>>> >> >>>> (or
>>> >> >>>>>>>>>>> when it
>>> >> >>>>>>>>>>> does), I'm +0 on changing,
by which I mean I don't care
>>> >>which
>>> >> >>>> we
>>> >> >>>> use.
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> Alan.
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> On Mar 20, 2012, at
11:22 PM, Jonathan Coveney wrote:
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> Would anyone be
opposed to doing this? I think you can
>>> >>apply
>>> >> >>>> to
>>> >> >>>> do
>>> >> >>>>>>>>>>>>> this
>>> >> >>>>>>>>>>> via
>>> >> >>>>>>>>>>>>> Apache, no? It
would be nice to make git the first
>>>class
>>> >> >>>> citizen of
>>> >> >>>>>>>>>>>>> choice... forcing
developers to use svn to work with
>>>pig
>>> >>is
>>> >> >>>> just
>>> >> >>>>>>>>>>>>> another
>>> >> >>>>>>>>>>>>> barrier, imho.
I thought this had been bandied about
>>>on
>>> >> >>>> Twitter
>>> >> >>>>>>>>>>>>> and the
>>> >> >>>>>>>>>>>>> like, but not sure
if it's been discussed seriously
>>>on the
>>> >> >>>>>>>>>>>>> listserv.
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> Would love y'all's
opinions on the matter
>>> >> >>>>>>>>>>>>> Jon
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> --
>>> >> >>>>>>>>>> *Note that I'm no longer using
my Yahoo! email address.
>>> >>Please
>>> >> >>>> email
>>> >> >>>>>>>>>> me at
>>> >> >>>>>>>>>> billgraham@gmail.com going
forward.*
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> >> >>> --
>>> >> >>> Russell Jurney twitter.com/rjurney russell.jurney@gmail.com
>>> >> >>> datasyndrome.com
>>> >> >>
>>> >> >>
>>> >> >
>>> >> >
>>> >> > --
>>> >> > Russell Jurney twitter.com/rjurney russell.jurney@gmail.com
>>> >> datasyndrome.com
>>> >>
>>>
>>>
>>
>>
>> --
>> Russell Jurney twitter.com/rjurney russell.jurney@gmail.com
>>datasyndrome.com


Mime
View raw message