pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2528) Add setScriptPlan() method to PigProgressNotificationListener
Date Mon, 13 Feb 2012 23:08:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207314#comment-13207314
] 

Alejandro Abdelnur commented on PIG-2528:
-----------------------------------------

Virag will answer in detail, but I think from Oozie's side we'd be OK with the interface change.

To avoid something like this happening in the future, would you consider adding a base class
implementing the interface with NOP methods and recommending to use that class instead of
the interface, by doing that you can add new functionality without breaking compatibility
(you'd add the new method to both the interface and the base class).
                
> Add setScriptPlan() method to PigProgressNotificationListener
> -------------------------------------------------------------
>
>                 Key: PIG-2528
>                 URL: https://issues.apache.org/jira/browse/PIG-2528
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: PIG-2528.patch
>
>
> For the purposes of tracing usage and statistics of Pig scripts, I'd like to be able
to correlate the information PPNL can now collect with the script that was actually running.
Currently, a script id gets passed into every PPNL call, but it's just a UUID, so one can't
compare it to other executions of the same script.
> It seems to me like most of what I need would be taken care of by adding a setScriptPlan(String
lp) method to the PPNL interface, and calling it from ScriptState's setScriptFeatures(LogicalPlan
lp). My PPNL could then walk the plan and come up with some representation that would be reusable
between different runs of the same script.
> This would be a backwards incompatible change, as it requires adding a method to an interface.
PPNL is labeled as evolving, and I don't believe that it's widely used at the moment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message