pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2403) Reduce code duplication in SUM, MAX, MIN udfs
Date Wed, 07 Dec 2011 06:34:39 GMT

    [ https://issues.apache.org/jira/browse/PIG-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164184#comment-13164184
] 

Dmitriy V. Ryaboy commented on PIG-2403:
----------------------------------------

Summary of changes:

$ git diff apache/trunk --stat
 .../pig/builtin/AlgebraicByteArrayMathBase.java    |  213 +++++++++++++++++++
 .../pig/builtin/AlgebraicDoubleMathBase.java       |  166 +++++++++++++++
 .../apache/pig/builtin/AlgebraicFloatMathBase.java |  165 +++++++++++++++
 .../apache/pig/builtin/AlgebraicIntMathBase.java   |  167 +++++++++++++++
 .../apache/pig/builtin/AlgebraicLongMathBase.java  |  168 +++++++++++++++
 src/org/apache/pig/builtin/AlgebraicMathBase.java  |  127 ++++++++++++
 src/org/apache/pig/builtin/DoubleAbs.java          |   35 +---
 src/org/apache/pig/builtin/DoubleMax.java          |  169 +---------------
 src/org/apache/pig/builtin/DoubleMin.java          |  165 +--------------
 src/org/apache/pig/builtin/DoubleSum.java          |  168 +--------------
 src/org/apache/pig/builtin/FloatMax.java           |  166 +--------------
 src/org/apache/pig/builtin/FloatMin.java           |  165 +--------------
 src/org/apache/pig/builtin/FloatSum.java           |  210 +-------------------
 src/org/apache/pig/builtin/IntMax.java             |  167 +--------------
 src/org/apache/pig/builtin/IntMin.java             |  167 +--------------
 src/org/apache/pig/builtin/IntSum.java             |  210 +-------------------
 src/org/apache/pig/builtin/LongMax.java            |  166 +--------------
 src/org/apache/pig/builtin/LongMin.java            |  165 +--------------
 src/org/apache/pig/builtin/LongSum.java            |  164 +--------------
 src/org/apache/pig/builtin/MAX.java                |  206 +------------------
 src/org/apache/pig/builtin/MIN.java                |  207 +------------------
 src/org/apache/pig/builtin/SUM.java                |  216 ++------------------
 22 files changed, 1138 insertions(+), 2614 deletions(-)

                
> Reduce code duplication in SUM, MAX, MIN udfs
> ---------------------------------------------
>
>                 Key: PIG-2403
>                 URL: https://issues.apache.org/jira/browse/PIG-2403
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.11
>
>         Attachments: PIG-2403.patch
>
>
> The current type-specific implementations of Max, Min, and Sum have a lot of duplicated
code. We can reduce this significantly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message