pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request: PIG-2228: support partial aggregation in map task
Date Thu, 15 Sep 2011 17:28:31 GMT


> On 2011-09-13 09:15:46, Dmitriy Ryaboy wrote:
> > trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLocalRearrange.java,
line 296
> > <https://reviews.apache.org/r/1817/diff/1/?file=40193#file40193line296>
> >
> >     Not sure about the value of this comment :)

cleaning that


- Thejas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1817/#review1868
-----------------------------------------------------------


On 2011-09-15 17:27:08, Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1817/
> -----------------------------------------------------------
> 
> (Updated 2011-09-15 17:27:08)
> 
> 
> Review request for pig, Daniel Dai and Dmitriy Ryaboy.
> 
> 
> Summary
> -------
> 
> See PIG-2228
> 
> 
> This addresses bug PIG-2228.
>     https://issues.apache.org/jira/browse/PIG-2228
> 
> 
> Diffs
> -----
> 
>   trunk/conf/pig.properties 1170885 
>   trunk/src/org/apache/pig/Algebraic.java 1170885 
>   trunk/src/org/apache/pig/Main.java 1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/CombinerOptimizer.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PhyPlanSetter.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/plans/EndOfAllInputSetter.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhyPlanVisitor.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PlanPrinter.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLocalRearrange.java
1170885 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java
PRE-CREATION 
>   trunk/src/org/apache/pig/data/DefaultTuple.java 1170885 
>   trunk/src/org/apache/pig/data/InternalCachedBag.java 1170885 
>   trunk/src/org/apache/pig/data/InternalDistinctBag.java 1170885 
>   trunk/src/org/apache/pig/data/InternalSortedBag.java 1170885 
>   trunk/src/org/apache/pig/data/SelfSpillBag.java PRE-CREATION 
>   trunk/src/org/apache/pig/data/SizeUtil.java PRE-CREATION 
>   trunk/src/org/apache/pig/data/SortedSpillBag.java 1170885 
>   trunk/src/org/apache/pig/tools/pigstats/ScriptState.java 1170885 
>   trunk/test/e2e/pig/tests/nightly.conf 1170885 
>   trunk/test/org/apache/pig/test/TestDataBag.java 1170885 
>   trunk/test/org/apache/pig/test/TestPOPartialAgg.java PRE-CREATION 
>   trunk/test/org/apache/pig/test/TestPOPartialAggPlan.java PRE-CREATION 
>   trunk/test/org/apache/pig/test/Util.java 1170885 
>   trunk/test/org/apache/pig/test/utils/GenPhyOp.java 1170885 
> 
> Diff: https://reviews.apache.org/r/1817/diff
> 
> 
> Testing
> -------
> 
> test-patch 
>      [exec] -1 overall.
>      [exec]
>      [exec]     +1 @author.  The patch does not contain any @author tags.
>      [exec]
>      [exec]     +1 tests included.  The patch appears to include 21 new or modified tests.
>      [exec]
>      [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
>      [exec]
>      [exec]     +1 javac.  The applied patch does not increase the total number of javac
compiler warnings.
>      [exec]
>      [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
>      [exec]
>      [exec]     -1 release audit.  The applied patch generated 461 release audit warnings
(more than the trunk's current 455 warnings).
> release audit failures are because of jdiff changes
> 
> All  unit tests pass, new e2e tests added .
> 
> 
> Thanks,
> 
> Thejas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message