pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2215) Newlines in function arguments still cause exceptions to be thrown
Date Fri, 12 Aug 2011 17:46:35 GMT

    [ https://issues.apache.org/jira/browse/PIG-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084280#comment-13084280
] 

Alan Gates commented on PIG-2215:
---------------------------------

Results from test patch:

     [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]
     [exec]
     [exec]

> Newlines in function arguments still cause exceptions to be thrown
> ------------------------------------------------------------------
>
>                 Key: PIG-2215
>                 URL: https://issues.apache.org/jira/browse/PIG-2215
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Adam Warrington
>            Assignee: Adam Warrington
>             Fix For: 0.10
>
>         Attachments: PIG-2215-0.patch
>
>
> PIG-1749 was an attempt to allow newlines in function arguments. It appears that the
AstValidator and the LogicalPlanGenerator grammars were not updated, so the following exception
and stracktrace will be thrown when executing a script that has newlines in function arguments:
> ERROR 1200: Pig script failed to parse: MismatchedTokenException(93!=3)
> Failed to parse: Pig script failed to parse: MismatchedTokenException(93!=3)
>         at org.apache.pig.parser.QueryParserDriver.parse(QueryParserDriver.java:178)
>         at org.apache.pig.PigServer$Graph.validateQuery(PigServer.java:1622)
>         at org.apache.pig.PigServer$Graph.registerQuery(PigServer.java:1595)
>         at org.apache.pig.PigServer.registerQuery(PigServer.java:583)
>         at org.apache.pig.tools.grunt.GruntParser.processPig(GruntParser.java:942)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:386)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.run(Grunt.java:67)
>         at org.apache.pig.Main.run(Main.java:487)
>         at org.apache.pig.Main.main(Main.java:108)
> Caused by: MismatchedTokenException(93!=3)
>         at org.apache.pig.parser.AstValidator.recoverFromMismatchedToken(AstValidator.java:209)
>         at org.antlr.runtime.BaseRecognizer.match(BaseRecognizer.java:115)
>         at org.apache.pig.parser.AstValidator.func_clause(AstValidator.java:3497)
>         at org.apache.pig.parser.AstValidator.load_clause(AstValidator.java:2464)
>         at org.apache.pig.parser.AstValidator.op_clause(AstValidator.java:934)
>         at org.apache.pig.parser.AstValidator.general_statement(AstValidator.java:574)
>         at org.apache.pig.parser.AstValidator.statement(AstValidator.java:396)
>         at org.apache.pig.parser.AstValidator.query(AstValidator.java:306)
>         at org.apache.pig.parser.QueryParserDriver.validateAst(QueryParserDriver.java:236)
>         at org.apache.pig.parser.QueryParserDriver.parse(QueryParserDriver.java:168)
>         ... 10 more

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message