Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C72348A1 for ; Fri, 13 May 2011 18:19:38 +0000 (UTC) Received: (qmail 73055 invoked by uid 500); 13 May 2011 18:13:41 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 73042 invoked by uid 500); 13 May 2011 18:13:40 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 73030 invoked by uid 99); 13 May 2011 18:13:39 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 18:13:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BF8E31C01AD; Fri, 13 May 2011 18:13:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2186315941264731503==" MIME-Version: 1.0 Subject: Re: Review Request: FilterLogicExpressionSimplifier removed some branches in some cases From: "Daniel Dai" To: "Richard Ding" Date: Fri, 13 May 2011 18:13:38 -0000 Message-ID: <20110513181338.18992.58828@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/743/ Cc: "pig" ,"Daniel Dai" In-Reply-To: <20110513165808.18992.82800@reviews.apache.org> References: <20110513165808.18992.82800@reviews.apache.org> --===============2186315941264731503== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/743/ ----------------------------------------------------------- (Updated 2011-05-13 18:13:38.714903) Review request for pig and Richard Ding. Summary ------- See PIG-2067 This addresses bug PIG-2067. https://issues.apache.org/jira/browse/PIG-2067 Diffs ----- http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logi= cal/expression/ProjectExpression.java 1102169 = http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logi= cal/expression/UserFuncExpression.java 1102169 = http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logi= cal/rules/LogicalExpressionSimplifier.java 1102169 = http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestFi= lterSimplification.java 1102169 = Diff: https://reviews.apache.org/r/743/diff Testing (updated) ------- Test-patch: [exec] -1 overall. = [exec] = [exec] +1 @author. The patch does not contain any @author tags. [exec] = [exec] +1 tests included. The patch appears to include 3 new or m= odified tests. [exec] = [exec] +1 javadoc. The javadoc tool did not generate any warning = messages. [exec] = [exec] +1 javac. The applied patch does not increase the total nu= mber of javac compiler warnings. [exec] = [exec] +1 findbugs. The patch does not introduce any new Findbugs= warnings. [exec] = [exec] -1 release audit. The applied patch generated 562 release = audit warnings (more than the trunk's current 561 warnings). Ignore release audit warning since no new file is added. Unit test: all pass End-to-end test: all pass Thanks, Daniel --===============2186315941264731503==--