Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 28EE13D8D for ; Thu, 28 Apr 2011 22:07:26 +0000 (UTC) Received: (qmail 63872 invoked by uid 500); 28 Apr 2011 22:07:26 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 63854 invoked by uid 500); 28 Apr 2011 22:07:26 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 63844 invoked by uid 99); 28 Apr 2011 22:07:25 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2011 22:07:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CC7E61C005A; Thu, 28 Apr 2011 22:07:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7519108111713905700==" MIME-Version: 1.0 Subject: Re: Review Request: complex type casting should return null on casting failure From: thejas.nair@yahoo.com To: thejas.nair@yahoo.com Date: Thu, 28 Apr 2011 22:07:25 -0000 Message-ID: <20110428220725.991.15354@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/673/ Cc: "pig" ,"Daniel Dai" In-Reply-To: <20110428205630.6699.54346@reviews.apache.org> References: <20110428205630.6699.54346@reviews.apache.org> --===============7519108111713905700== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/673/#review606 ----------------------------------------------------------- Ship it! +1 - thejas On 2011-04-28 20:56:30, Daniel Dai wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/673/ > ----------------------------------------------------------- > = > (Updated 2011-04-28 20:56:30) > = > = > Review request for pig and thejas. > = > = > Summary > ------- > = > See PIG-1989 > = > = > This addresses bug PIG-1989. > https://issues.apache.org/jira/browse/PIG-1989 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/ha= doop/executionengine/physicalLayer/expressionOperators/POCast.java 1097304 = > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/Test= POCast.java 1097304 = > = > Diff: https://reviews.apache.org/r/673/diff > = > = > Testing > ------- > = > Test-patch: > [exec] +1 overall. = > [exec] = > [exec] +1 @author. The patch does not contain any @author tags. > [exec] = > [exec] +1 tests included. The patch appears to include 3 new or= modified tests. > [exec] = > [exec] +1 javadoc. The javadoc tool did not generate any warnin= g messages. > [exec] = > [exec] +1 javac. The applied patch does not increase the total = number of javac compiler warnings. > [exec] = > [exec] +1 findbugs. The patch does not introduce any new Findbu= gs warnings. > [exec] = > [exec] +1 release audit. The applied patch does not increase th= e total number of release audit warnings. > = > Unit test: > all pass > = > = > Thanks, > = > Daniel > = > --===============7519108111713905700==--