pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thejas.n...@yahoo.com
Subject Re: Review Request: complex type casting should return null on casting failure
Date Thu, 28 Apr 2011 22:07:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/673/#review606
-----------------------------------------------------------

Ship it!


+1

- thejas


On 2011-04-28 20:56:30, Daniel Dai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2011-04-28 20:56:30)
> 
> 
> Review request for pig and thejas.
> 
> 
> Summary
> -------
> 
> See PIG-1989
> 
> 
> This addresses bug PIG-1989.
>     https://issues.apache.org/jira/browse/PIG-1989
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
1097304 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPOCast.java
1097304 
> 
> Diff: https://reviews.apache.org/r/673/diff
> 
> 
> Testing
> -------
> 
> Test-patch:
>      [exec] +1 overall.  
>      [exec] 
>      [exec]     +1 @author.  The patch does not contain any @author tags.
>      [exec] 
>      [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
>      [exec] 
>      [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
>      [exec] 
>      [exec]     +1 javac.  The applied patch does not increase the total number of javac
compiler warnings.
>      [exec] 
>      [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
>      [exec] 
>      [exec]     +1 release audit.  The applied patch does not increase the total number
of release audit warnings.
> 
> Unit test:
>     all pass
> 
> 
> Thanks,
> 
> Daniel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message