pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1618) Switch to new parser generator technology
Date Fri, 11 Mar 2011 00:52:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005436#comment-13005436
] 

Daniel Dai commented on PIG-1618:
---------------------------------

Review comments for typechecker, lineage, projectStarExpander:
Patch looks very good. Only two minor comments:
1. We need to print out CompilationMessageCollector warnings in PigServer
2. Seems we does not handle the case "foreach generate *, *". It is not a major use case,
but should be addressed for completeness.

> Switch to new parser generator technology
> -----------------------------------------
>
>                 Key: PIG-1618
>                 URL: https://issues.apache.org/jira/browse/PIG-1618
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Alan Gates
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: NewParser-1.patch, NewParser-10.patch, NewParser-11.patch, NewParser-12.patch,
NewParser-13.2.patch, NewParser-13.patch, NewParser-14.patch, NewParser-15.patch, NewParser-18.patch,
NewParser-19.3.patch, NewParser-19.patch, NewParser-2.patch, NewParser-21.patch, NewParser-22.patch,
NewParser-23.2.patch, NewParser-23.patch, NewParser-24.patch, NewParser-3.patch, NewParser-3.patch,
NewParser-4.patch, NewParser-5.patch, NewParser-6.patch, NewParser-7.patch, NewParser-8.patches,
NewParser-9.patch, antlr-3.2.jar, javadoc.patch
>
>
> There are many bugs in Pig related to the parser, particularly to bad error messages.
 After review of Java CC we feel these will be difficult to address using that tool.  Also,
the .jjt files used by JavaCC are hard to understand and maintain.  
> ANTLR is being reviewed as the most likely choice to move to, but other parsers will
be reviewed as well.
> This JIRA will act as an umbrella issue for other parser issues.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message