Mailing-List: contact dev-help@pig.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pig.apache.org
Content-Type: multipart/alternative;
	boundary="===============0581984157024247804=="
MIME-Version: 1.0
Subject: Review Request: New logical plan: FilterLogicExpressionSimplifier
 fail to
 deal with UDF
From: "Daniel Dai" <daijyc@gmail.com>
To: "Xuefu Zhang" <xuefuz@yahoo-inc.com>
Date: Wed, 26 Jan 2011 17:58:25 -0000
Message-ID: <20110126175825.31569.18137@reviews.apache.org>
Cc: "pig" <dev@pig.apache.org>, "Daniel Dai" <daijyc@gmail.com>

--===============0581984157024247804==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/356/
-----------------------------------------------------------

Review request for pig and Xuefu Zhang.


Summary
-------

The following script fail:

a =3D load '1.txt' as (a0, a1);
b =3D filter a by (a0 is not null or a1 is not null) and IsEmpty(a0);
explain b;

Error message:
Caused by: java.lang.ClassCastException: org.apache.pig.newplan.logical.exp=
ression.UserFuncExpression cannot be cast to org.apache.pig.newplan.logical=
.expression.BinaryExpression
at org.apache.pig.newplan.logical.rules.LogicalExpressionSimplifier$Logical=
ExpressionSimplifierTransformer.handleBinary(LogicalExpressionSimplifier.ja=
va:561)
at org.apache.pig.newplan.logical.rules.LogicalExpressionSimplifier$Logical=
ExpressionSimplifierTransformer.handleAnd(LogicalExpressionSimplifier.java:=
429)
at org.apache.pig.newplan.logical.rules.LogicalExpressionSimplifier$Logical=
ExpressionSimplifierTransformer.inferRelationship(LogicalExpressionSimplifi=
er.java:397)
at org.apache.pig.newplan.logical.rules.LogicalExpressionSimplifier$Logical=
ExpressionSimplifierTransformer.handleDNFOr(LogicalExpressionSimplifier.jav=
a:281)
at org.apache.pig.newplan.logical.rules.LogicalExpressionSimplifier$Logical=
ExpressionSimplifierTransformer.checkDNFLeaves(LogicalExpressionSimplifier.=
java:192)
at org.apache.pig.newplan.logical.rules.LogicalExpressionSimplifier$Logical=
ExpressionSimplifierTransformer.transform(LogicalExpressionSimplifier.java:=
108)
at org.apache.pig.newplan.optimizer.PlanOptimizer.optimize(PlanOptimizer.ja=
va:110)


This addresses bug PIG-1820.
    https://issues.apache.org/jira/browse/PIG-1820


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logi=
cal/rules/LogicalExpressionSimplifier.java 1062989 =

  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestFi=
lterSimplification.java 1062989 =


Diff: https://reviews.apache.org/r/356/diff


Testing
-------

Test-patch:
     [exec] +1 overall.  =

     [exec] =

     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] =

     [exec]     +1 tests included.  The patch appears to include 3 new or m=
odified tests.
     [exec] =

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning =
messages.
     [exec] =

     [exec]     +1 javac.  The applied patch does not increase the total nu=
mber of javac compiler warnings.
     [exec] =

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs=
 warnings.
     [exec] =

     [exec]     +1 release audit.  The applied patch does not increase the =
total number of release audit warnings.

Unit test:
    all pass

End-to-end test:
    all pass


Thanks,

Daniel


--===============0581984157024247804==--