pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-1755) Clean up duplicated code in Physical Operators
Date Sat, 11 Dec 2010 22:48:00 GMT

     [ https://issues.apache.org/jira/browse/PIG-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dmitriy V. Ryaboy updated PIG-1755:
-----------------------------------

    Attachment: PIG-1755.2.patch

I mean bytes, not an enum (forgot which it was).

Attached patch is rewritten to use DataType, and also modifies a number of the logical expression
operators to get rid of (some of) the code duplication in them.

Scott -- the purpose here is not to speed things up, though of course I don't want to slow
them down. However -- any ideas on how to reduce object allocations?

-D

> Clean up duplicated code in Physical Operators
> ----------------------------------------------
>
>                 Key: PIG-1755
>                 URL: https://issues.apache.org/jira/browse/PIG-1755
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: PIG-1755.2.patch, PIG-1755.patch
>
>
> A lot of the getNext() implementations in PhysicalOperators is copy-pasted, with only
the method signatures and casts changing. 
> Shorter code leads to less bugs and is easier to read.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message