pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai" <dai...@gmail.com>
Subject Re: Review Request: Update pig parser to allow function arguments to contain multiple lines
Date Fri, 10 Dec 2010 18:40:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/154/#review66
-----------------------------------------------------------



trunk/src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt
<https://reviews.apache.org/r/154/#comment54>

    The QueryParser will go away in 0.9 release. We will switch the parser (https://issues.apache.org/jira/browse/PIG-1618)
in couple of months. So shall we wait for the new parser?



trunk/src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt
<https://reviews.apache.org/r/154/#comment53>

    I prefer to allow multiple line support to all strings. Only allow function arguments
taking multiple lines seems confusing to the user.



trunk/test/org/apache/pig/test/TestParamSubPreproc.java
<https://reviews.apache.org/r/154/#comment52>

    Can you add a test case to test QueryParser itself?


- Daniel


On 2010-12-09 01:26:33, Lin Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/154/
> -----------------------------------------------------------
> 
> (Updated 2010-12-09 01:26:33)
> 
> 
> Review request for pig.
> 
> 
> Summary
> -------
> 
> Summary:
> 
> We want to extend pig parser to allow function arguments to contain multiple lines as
well as string list, like
> 
> STORE data INTO 'testOut' 
> USING storage.avro.AvroStorage (
> '{"debug": 5,
>   "data": "/user/lguo/testOut/ComponentActTracking4/part-m-00000.avro",
>   "field0": "int",
>   "field1": "def:browser_id",
>   "field3": "def:act_content" } '
> );
> 
> 
> This addresses bug PIG-1749.
>     https://issues.apache.org/jira/browse/PIG-1749
> 
> 
> Diffs
> -----
> 
>   trunk/src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt 1040872 
>   trunk/test/org/apache/pig/test/TestParamSubPreproc.java 1040872 
> 
> Diff: https://reviews.apache.org/r/154/diff
> 
> 
> Testing
> -------
> 
>      [exec] 
>      [exec] +1 overall.  
>      [exec] 
>      [exec]     +1 @author.  The patch does not contain any @author tags.
>      [exec] 
>      [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
>      [exec] 
>      [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
>      [exec] 
>      [exec]     +1 javac.  The applied patch does not increase the total number of javac
compiler warnings.
>      [exec] 
>      [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
>      [exec] 
>      [exec]     +1 release audit.  The applied patch does not increase the total number
of release audit warnings.
>      [exec] 
>      [exec] 
> 
> 
> Thanks,
> 
> Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message