pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai" <dai...@gmail.com>
Subject Review Request: Disable converting bytes loading from BinStorage
Date Wed, 01 Dec 2010 01:16:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/134/
-----------------------------------------------------------

Review request for pig.


Summary
-------

Change behavior of converting bytes loading from BinStorage.
1. Converting bytes loading from BinStorage() will now result an error.
2. If user clearly understand that the data is load from PigStorage (or other LoadFunc using
Utf8StorageConverter), he/she should use BinStorageWithCaster. By doing this, converting bytes
to other type will still work.


This addresses bug PIG-1745.
    https://issues.apache.org/jira/browse/PIG-1745


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/BinStorage.java 1040653

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/BinStorageWithCaster.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1040653 

Diff: https://reviews.apache.org/r/134/diff


Testing
-------


Thanks,

Daniel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message