Mailing-List: contact pig-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: pig-dev@hadoop.apache.org
Message-ID: <32587983.67241277503011537.JavaMail.jira@thor>
Date: Fri, 25 Jun 2010 17:56:51 -0400 (EDT)
From: "Alan Gates (JIRA)" <jira@apache.org>
To: pig-dev@hadoop.apache.org
Subject: [jira] Commented: (PIG-1466) Improve log messages for memory usage
In-Reply-To: <19322370.65931277498329898.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PIG-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882731#action_12882731 ] 

Alan Gates commented on PIG-1466:
---------------------------------

Rather than change the log level can we change it to only print when we truly spill a {{DefaultBag}}?  It would be nice to know if there are any cases where we are still doing that.

> Improve log messages for memory usage
> -------------------------------------
>
>                 Key: PIG-1466
>                 URL: https://issues.apache.org/jira/browse/PIG-1466
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Ashutosh Chauhan
>            Priority: Minor
>
> For anything more then a moderately sized dataset Pig usually spits following messages:
> {code}
> 2010-05-27 18:28:31,659 INFO org.apache.pig.impl.util.SpillableMemoryManager: low memory handler called (Usage
> threshold exceeded) init = 4194304(4096K) used = 672012960(656262K) committed = 954466304(932096K) max =
> 954466304(932096K)
> 2010-05-27 18:10:52,653 INFO org.apache.pig.impl.util.SpillableMemoryManager: low memory handler called (Collection
> threshold exceeded) init = 4194304(4096K) used = 954466304(932096K) committed = 954466304(932096K) max =
> 954466304(932096K)
> {code}
> This seems to confuse users a lot. Once these messages are printed, users tend to believe that Pig is having hard time with memory, is spilling to disk etc. but in fact Pig might be cruising along at ease. We should be little more careful what to print in logs. Currently these are printed when a notification is sent by JVM and some other conditions are met which may not necessarily indicate low memory condition. Furthermore, with {{InternalCachedBag}} embraced everywhere in favor of {{DefaultBag}}, these messages have lost their usefulness. At the every least, we should lower the log level at which these are printed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.