pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1351) [Zebra] No type check when we write to the basic table
Date Thu, 15 Apr 2010 22:02:49 GMT

    [ https://issues.apache.org/jira/browse/PIG-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857564#action_12857564
] 

Hadoop QA commented on PIG-1351:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12441851/PIG-1351.patch
  against trunk revision 934488.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 174 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/292/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/292/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/292/console

This message is automatically generated.

> [Zebra] No type check when we write to the basic table
> ------------------------------------------------------
>
>                 Key: PIG-1351
>                 URL: https://issues.apache.org/jira/browse/PIG-1351
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>             Fix For: 0.8.0
>
>         Attachments: PIG-1351.patch, PIG-1351.patch
>
>
> In Zebra, we do not have any type check when writing to a basic table. 
> Say, we have a schema: "f1:int, f2:string",
> however we can write a tuple ("abc", 123) without any problem, which is definitely not
desirable.
> To overcome this problem, we decide to perform certain amount of type checking in Zebra
- We check the first row only for each writer.
> This only serves as a sanity check purpose in cases where users screw up specifying the
output schema. We do NOT perform a rigorous type checking for all rows for apparently performance
concerns.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message